A fill valve assembly for a toilet tank is described. The fill valve assembly includes a two part design. The fill valve assembly includes a fill valve that connects or engages with a shank. A connection between the fill valve and the shank is located in an interior of the tank, which is easily accessed. The fill valve may be easily replaced by disconnecting the fill valve from the shank.