A liquid level detecting device includes a sensor housing, a holder, an arm fixing portion provided in the holder, a float arm, a float, a magnet provided in the holder, and a Hall element. The arm fixing portion includes a lock hole configured to receive a lock end portion of the float arm, a holding portion having a holding groove, and a retaining portion having a claw. The holding portion has a holding piece that extends parallel with a front surface of the holder and thereby forms the holding groove. The holding piece has a holding projection that projects toward the front surface of the holder so that a projection length of the holding projection increases gradually as the holding piece goes away from the lock hole.