A liquid level detecting device includes a sensor housing having a circular rotation recess, a circular holder which is fitted in the rotation recess and held rotatably by the sensor housing, a float arm, a float, a magnet, and a Hall element. The sensor housing has a lock groove and a pair of insertion holes. The holder has a pair of flanges which project in opposite directions from an outer circumferential surface of the holder and are engaged with the lock groove and prevented from coming off the rotation recess by setting the flanges opposed to the respective insertion holes, fitting the flanges into the rotation recess, and then rotating the flanges. The holder has a pair of support projections which come into contact with a bottom surface of the rotation recess.