The present invention is an on-camera flashlight, comprising a lower light holder and a top light holder freely rotatably connected to the lower light holder. A flashlight light source is mounted on the top of the top light holder. The light emitting diode and the flashlight light source are mounted on the on-camera flashlight, combined for ease of use. Two functions-in-one lighting device saves space, avoids overloading the camera, and makes it portable. Because the two light sources are set in combination, the cooperation and sequence of the two light sources are easier to control. As the light emitting diode is mounted on the top light holder which may freely rotate with respect to the lower light holder, the light emitting diode may also freely rotate. It is also convenient to adjust the light direction. Above features all remarkably facilitate operation and versatility of the on-camera flashlight.