The present disclosure provides diacylglycerol kinase modulating compounds, and pharmaceutical compositions thereof, for treating cancer, including solid tumors, and viral infections, such as HIV or hepatitis B virus infection. The compounds can be used alone or in combination with other agents.