A sound generating assembly and an electronic device having the same are provided. The sound generating assembly comprises a bracket, two sides of the bracket are respectively connected with a housing and a cover having a through slot, and the cover is configured to move in a direction facing the housing or a direction away from the housing, a contact is provided between the bracket and the housing and is configured to move synchronously with the cover, an end of the contact that is away from the cover is provided with a sounding elastic piece, when the cover moves in a direction facing the housing and an upper surface of the bracket is exposed from the through slot, the sounding elastic piece is deformed and making a sound after being pressed by the contact.