A door weather strip includes a base attached along the outer periphery of a door frame and a hollow seal, and a clip attached to the base. The clip includes an engaging part fit in and enagageable with an attaching hole in the door frame and a retained part retained to the base. The retained part includes a retaining piece and a coupling portion coupling the center area of the retaining piece in the longitudinal direction and the engaging part. Using an inserting means equipped with an insertion pin which is nearly cylindrical and sharp-pointed, the insertion pin is pierced into the base so that the retaining piece is fed through the inner peripheral side of the insertion pin to the inner face side of the base, thereby attaching the clip to the base.