A method of producing a plurality of effusion holes in a wall of a combustor of a gas turbine engine comprises: determining a hole pattern definition which provides a functional relationship of the spacing between each adjacent hole within the row of holes; using the hole pattern definition to identify individual positions of the effusion holes to be produced; and using a hole producing system to produce the effusion holes at the identified positions.